Implement the ability to rename a profile #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make the rename profile button not overlap the create profile button? It should look the same as remove profile. See attached heavily enhanced screenshot. |
|
Also instead of making a new form can we just have frmNameDialog also do this? frmCustomInputBox from the main project might be helpful for an idea of how that could be accomplished. |
|
Fixed the buttons and re-used frmNameDialog. |
|
Anything I'm missing? |
|
What is left for this PR? |
There was already skeleton code in the launcher to rename a profile but there was no button or actual logic to do so. A new form has been created to assist in renaming a profile
MisterVector
force-pushed
the
RenameProfile
branch
from
06c7d7b to
bb21c75
Compare
|
Rebased on top of latest changes from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was already skeleton code in the launcher to rename a profile but
there was no button or actual logic to do so. A new form has been created
to assist in renaming a profile