Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(integration): update macOS version in integration tests #1383

Merged
merged 1 commit into from
Oct 18, 2024
Merged

ci(integration): update macOS version in integration tests #1383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions .github/workflows/integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-12]
os: [ubuntu-latest, windows-latest, macos-13]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Issues Found: macOS-13 Integration Job Failed

The integration tests on macos-13 concluded with a failure. This indicates that the update may have introduced issues or uncovered existing problems specific to the newer macOS version.

  • Affected job: integration (macos-13)
🔗 Analysis chain

Approved: macOS version update in job matrix

The update from macos-12 to macos-13 in the job matrix aligns with the PR objective and can potentially improve compatibility with newer macOS versions.

To ensure this change doesn't introduce any unexpected issues, please verify that all tests pass successfully on the new macOS-13 environment. You can check this by running the following command to examine the workflow run results:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

gh run list --workflow=integration-test.yml --limit 1 --json conclusion,jobs | jq '.[0].jobs[] | select(.name | contains("macos")) | {name, conclusion}'

Length of output: 424

Script:

#!/bin/bash
# Fetch the latest run ID for the integration-test.yml workflow
run_id=$(gh run list --workflow=integration-test.yml --limit 1 --json databaseId --jq '.[0].databaseId')

# Retrieve job details for the fetched run ID
gh run view $run_id --json jobs -q '.jobs[] | select(.name | contains("macos")) | {name, conclusion}'

Length of output: 283


runs-on: ${{ matrix.os }}

Expand All @@ -27,13 +27,7 @@ jobs:
# fix for GitHub actions MacOS
- name: Setup docker
if: runner.os == 'macos' && steps.changes.outputs.go == 'true'
run: |
brew install docker
colima start

# For testcontainers to find the Colima socket
# https://github.com/abiosoft/colima/blob/main/docs/FAQ.md#cannot-connect-to-the-docker-daemon-at-unixvarrundockersock-is-the-docker-daemon-running
sudo ln -sf $HOME/.colima/default/docker.sock /var/run/docker.sock
uses: douglascamata/setup-docker-macos-action@v1-alpha

- uses: actions/cache@v4
with:
Expand Down Expand Up @@ -66,17 +60,6 @@ jobs:
- '**/*.sum'
- '**/*.work'

# fix for GitHub actions MacOS
- name: Setup docker
if: runner.os == 'macos' && steps.changes.outputs.go == 'true'
run: |
brew install docker
colima start

# For testcontainers to find the Colima socket
# https://github.com/abiosoft/colima/blob/main/docs/FAQ.md#cannot-connect-to-the-docker-daemon-at-unixvarrundockersock-is-the-docker-daemon-running
sudo ln -sf $HOME/.colima/default/docker.sock /var/run/docker.sock

- uses: actions/cache@v4
with:
path: |
Expand Down
Loading