feat(templates): embed templates in go binary #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steebchen
changed the title
|
Thanks, this is awesome! |
steebchen
changed the title
steebchen
pushed a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to integrate prisma-client-go into the bazel ecosystem (a polyglot ORM generator deserves a polyglot build system 😄), but I hit a snag when the prisma-client-go binary was calling
go list github.com/steebchen/prisma-client-goviactx.Import.Calling the go sdk directly inside bazel requires a tricky workaround, but embedding the templates directly into the binary seemed a lot simpler (and more portable!) so I created this pull request in case you wanted to merge it upstream too.
Tests pass with
go generate ./... && go test ./... -v