Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#proposal 86 hide resteems #3930

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

the-gorilla-steem
Copy link
Contributor

@the-gorilla-steem the-gorilla-steem commented Dec 3, 2024

These changes add "Hide Resteems" functionality to all Friends Feeds and improves the layout of the Community Banner on mobile devices (when there are a large number of subscribers or rewards).

@ety001 - Could you deploy to steemitdev please?

Fixed bug steemit#3929 (View / Collapse Doesn't Work with 2 Pinned Posts)
In combination with bug fix commit - this is the remaining code to implement the hiding of Resteems within a Feed.
Improved the display of the community banner on mobile devices for the following scenarios:
* A community with a large number of subscribers and/or large pending rewards
* A community with a long description
Introduced translations for the "Hide Resteems" label as well as removing comments used whilst debugging.
Adjusted how the feed being viewed is determined.
@ety001
Copy link
Member

ety001 commented Dec 5, 2024

@the-gorilla-steem
Hi, it has been deployed to the dev env. Please test it.

1. Adjusted the colours of the "Next" and "Back" button so that they adjust with the theme (light / dark mode).
2. Tweaked the display of subscribers, pending rewards and active authors on mobile devices so that figures > 10,000 use 10k, 1m, etc. and 1 decimal place.
@the-gorilla-steem
Copy link
Contributor Author

@ety001
Hello, it's looking good. I have made a couple of minor adjustments - please can you redeploy, ready for a final test.

@ety001
Copy link
Member

ety001 commented Dec 7, 2024

@the-gorilla-steem
Hi, it was deployed. Please test.

@the-gorilla-steem
Copy link
Contributor Author

the-gorilla-steem commented Dec 13, 2024

@ety001 - Thank you. I'm going to spend a little time tweaking it a little more. The functionality works as it should but I can improve its appearance so I will spend a bit of time doing that.

Adjusted the positioning and spacing around the "Hide Resteems" button to make it look nicer on mobile and desktop.
@the-gorilla-steem
Copy link
Contributor Author

Hi @ety001 - adjustments made. Please redeploy to steemitdev when you can. Thank you.

@ety001
Copy link
Member

ety001 commented Dec 14, 2024

@the-gorilla-steem
Hi, it was deployed. Please test.

@the-gorilla-steem
Copy link
Contributor Author

Thanks @ety001. This has tested well and I'm happy for this to go live. Thank you 👍

@ety001 ety001 merged commit ec88f73 into steemit:master Dec 20, 2024
1 check passed
the-gorilla-steem added a commit to the-gorilla-steem/condenser that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants