Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't retry sign up if previous email unconfirmed #265

Open
roadscape opened this issue Mar 22, 2018 · 0 comments · Fixed by #340
Open

can't retry sign up if previous email unconfirmed #265

roadscape opened this issue Mar 22, 2018 · 0 comments · Fixed by #340
Assignees
@bnchdrff
Labels
2 bug project/signup

Comments

@roadscape
Copy link
Contributor

To reproduce:

  1. Go through signup, do not confirm email
  2. Restart signup, use same email; nothing happens when you click 'Continue'

It appears to override 'username' field of the existing pending entry; not sure this is wise. Faucet should allow multiple unverified records to exist with the same email. Uniqueness should only be enforced among verified emails.

This behavior seems to be accompanied by Unhandled rejection Error: Can't set headers after they are sent. in the logs, which might explain why nothing happens (no visual feedback anyway) when one clicks 'Continue' in the 2nd step.
@roadscape roadscape added the bug label Mar 22, 2018
@jnordberg jnordberg mentioned this issue Mar 23, 2018
Merged
@roadscape roadscape changed the title problems trying to sign up 2nd time using unconfirmed email can't retry sign up when previous email held, unconfirmed Apr 2, 2018
@roadscape roadscape changed the title can't retry sign up when previous email held, unconfirmed can't retry sign up if previous email unconfirmed Apr 2, 2018
@pkattera pkattera added the 2 label Apr 3, 2018
@bnchdrff bnchdrff self-assigned this Apr 17, 2018
bnchdrff added a commit that referenced this issue May 7, 2018
@bnchdrff
refactor routes into testable functions & add test
33692f7 
closes #265 by searching for user based on username and email match

also, check for captcha sooner
bnchdrff added a commit that referenced this issue May 7, 2018
@bnchdrff
refactor routes into testable functions & add test
28a0b08 
closes #265 by searching for user based on username and email match

also, check for captcha sooner
bnchdrff added a commit that referenced this issue May 7, 2018
@bnchdrff
refactor routes into testable functions & add test
fc90737 
closes #265 by searching for user based on username and email match

also, check for captcha sooner
bnchdrff added a commit that referenced this issue May 7, 2018
@bnchdrff
refactor routes into testable functions & add test
7a6038b 
closes #265 by searching for user based on username and email match

also, check for captcha sooner
@bnchdrff bnchdrff mentioned this issue May 7, 2018
Merged
bnchdrff added a commit that referenced this issue May 8, 2018
@bnchdrff
revert fix for #265
c8a537e
@jnordberg jnordberg reopened this May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnchdrff bnchdrff

Labels
2 bug project/signup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor routes into testable functions & add test steemit/faucet
4 participants
@jnordberg @bnchdrff @pkattera @roadscape