Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor routes into testable functions & add test #340

Merged
merged 4 commits into from
May 8, 2018
Merged

Conversation

bnchdrff
Copy link
Contributor

@bnchdrff bnchdrff commented May 7, 2018

closes #265 by searching for user based on username and email match waiting to do the fix commit

bnchdrff added 2 commits May 7, 2018 11:29
closes #265 by searching for user based on username and email match

also, check for captcha sooner
@bnchdrff bnchdrff requested a review from jnordberg May 7, 2018 17:01
Copy link
Contributor

@jnordberg jnordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK barring that the change to handleRequestEmail is reverted since it will have side effects that should be reviewed further in another PR

@bnchdrff bnchdrff merged commit bd97f66 into master May 8, 2018
@jnordberg jnordberg deleted the 265-many-emails branch May 9, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't retry sign up if previous email unconfirmed
2 participants