-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added lz4io #33
base: master
Are you sure you want to change the base?
Added lz4io #33
Conversation
Can you undo the changes to lz4 files? I'd rather have these changes upstream, and simply mirror them here cc @Cyan4973 for upstream |
Otherwise, good job! |
Thank you, for the compliment! |
Steeve, I created a new branch from the earlier r119 commit, which has almost of the lz4 files matching. The only one that doesn't is lz4hc.h, since your version is r91 not r119. lz4io requires some functions that are only present in r119 header, so adding the r119 lz4hc.h was a necessity, sorry. If you want, I can close this pull request and do a new request from the branch matching all of your r119 files. |
a5ab2ec
to
6fe9e29
Compare
Just wanted to leave you with a side note. On the compressFileAdv, for the docstring I did not list blockMode because with r119 it segfaults on chained blocks. On r122 it does not. Once this is commited, and updated to r122, I'll add blockMode to the docstring. It's still in the ParseTupleAndKeywords as an option, I just don't want them using it until the update to r122. |
Added bindings for lz4io as decompressFileDefault and compressFileAdv and compressFileDefault. Updated setup.py to include new headers. Updated test.py with a file test, running md5 against source, and a result of compressing/decompressing.