Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable type check due to error: Argument type mismatch #52

Merged
merged 6 commits into from
Nov 18, 2023
Merged

Disable type check due to error: Argument type mismatch #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
204dc5f
Disable type check due to error: Argument type mismatch
stefro Nov 18, 2023
246760c
Add test coverage check to pull request template
stefro Nov 18, 2023
fce288a
Add coverage configuration to phpunit.xml
stefro Nov 18, 2023
f39a1c3
Enable type checking in tests for Laravel 10.* with prefer-stable dep…
stefro Nov 18, 2023
4c14892
Temporarily disable type check due to error. Add example tests
stefro Nov 18, 2023
7c20350
Delete example tests
stefro Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
- name: Execute tests
run: composer test:coverage

- name: Type check
if: ${{ contains(matrix.laravel, '10.*') && contains(matrix.dependency-version, 'prefer-stable') }}
run: composer type:check
# Temporarily disabled due to error: Argument #9 ($signatureMapProvider) must be of type PHPStan\Reflection\SignatureMap\SignatureMapProvider, PHPStan\PhpDoc\PhpDocInheritanceResolver given
# - name: Type check
# if: ${{ contains(matrix.laravel, '10.*') && contains(matrix.dependency-version, 'prefer-stable') }}
# run: composer type:check
2 changes: 2 additions & 0 deletions PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ see how your change affects other areas of the code, etc.
## Types of changes

What types of changes does your code introduce? Put an `x` in all the boxes that apply:

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Expand All @@ -38,6 +39,7 @@ Please, please, please, don't send your pull request until all of the boxes are
- [ ] I have created a branch for this patch/feature.
- [ ] Each individual commit in the pull request is meaningful.
- [ ] I have added tests to cover my changes.
- [ ] I ran tests locally with `composer test:coverage` and it passed.
- [ ] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!
5 changes: 5 additions & 0 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,9 @@
<directory suffix=".php">./src</directory>
</include>
</source>
<coverage>
<include>
<directory suffix=".php">./src</directory>
</include>
</coverage>
</phpunit>
Loading