Add general corrections, add fixes to be able to compile the book #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #2, partially #3 (was is just rebuilding that fixed the typesetting issue?), & #9.
I had to employ some dirty fixes to make it work due to missing datasets. This has been raised in #1 already, and it is understandable you might not be able to share all of the data due to it being personal. I'd suggest using synthetic datasets (I could give you a hand with this one!) or find a replacement. It's difficult to reproduce any results without the dataset itself. But I digress. One of the remaining issues is that the following bit fails
fimdbook/R/fimd.R
Line 2451 in 6627496
In my case I had to replace it with
However, I'm not sure if it's the code itself or my borked data that causes this. Feel free to add the change if you know what's right.
Also, there is some redundant code left, and there is little context to choose one of the lines:
fimdbook/R/fimd.R
Lines 2375 to 2376 in 6627496
Finally, I'd change the default branch to this one to let people know explicitly the latest corrected version available.