Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue35 #36

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Issue35 #36

wants to merge 2 commits into from

Conversation

ferrighi
Copy link
Collaborator

This PR closes #35 . It contains:

  • update of the vocab tool, with extraction of platform and instrument information (short name, long name and wmo reference)
  • the latest updated version of the vocabulary terms
  • a modification of nc_to_mmd where given the platform attribute
    • it checks if the preferred name is provided either as string (short name) or in paranthesis (e.g. long name (short name)) and it populates long_name and resource through vocab.
    • it supports both single string and comma separated
    • it adds instrument using the same approach as for platforms

For now, the length of platform and instrument must be the same, since in MMD the instrument is a child of platform. This could be improved when other types of platforms/instrument are supported. Alternatively, the isHostedBy/hosts statements could be used from vocab to establish if one instrument can be linked to several platforms (in case of mismatching lengths).

@ferrighi ferrighi requested a review from steingod September 20, 2024 14:35
Copy link
Owner

@steingod steingod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if a platform or instrument is not in the list? If this happens a separate error report or similar should be generated so we can update the controlled vocabularies over time. Same with instruments. As it is now it only reflects satellite remote sensing, but the MMD specification as such does not constrain it to such. It could be used to name a research vessel as well and these have less formal naming governance of lists than satellites. I would suggest to let more through with a possible warning list generated.

@ferrighi ferrighi marked this pull request as draft November 20, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate vocab for extraction of platform information
2 participants