Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue16 #47

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Issue16 #47

wants to merge 4 commits into from

Conversation

ferrighi
Copy link
Collaborator

This is a major revision of harvestschemaorg.py. It should cover all elements defined in #16

This version should work in prod environment without addition of new modules.

Main points:

  • comment out requests_html/extruct and extract_metadata function. Added a dedicated new function pangaeaapicall: endpoints will lazy loading are now not covered. This needs to be rewritten finding a better module/library.
  • improving and extending mapping
  • improving content validation (license and temporal element)
  • add several checks on field type (dict/str/list) and their presence (many are optional fields)
  • improving identifier/url extraction logics

Additional notes for future cleaning/improvements:

  • extending supported vocabularies
  • create logic to extract related_information/citation if presented as CreativeWork/Article
  • add contributor field
  • push prints into logging

@ferrighi ferrighi requested a review from steingod February 21, 2025 12:20
@ferrighi ferrighi marked this pull request as draft February 26, 2025 15:13
@ferrighi
Copy link
Collaborator Author

I will add the feedback from pangaea before merging. Converting to draft.

@ferrighi ferrighi marked this pull request as ready for review February 26, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant