[YUNIKORN-1093] Track rejected applications

steinsgateted · Mar 5, 2022 · 9f21923 · 9f21923
1 parent ddfb70d
commit 9f21923
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/scheduler/objects/application.go b/pkg/scheduler/objects/application.go
@@ -105,6 +105,7 @@ func NewApplication(siApp *si.AddApplicationRequest, ugi security.UserGroup, eve
 		stateMachine:         NewAppState(),
 		placeholderAsk:       resources.NewResourceFromProto(siApp.PlaceholderAsk),
 		finishedTime:         time.Time{},
+		rejectionMessage:     "",
 	}
 	placeholderTimeout := common.ConvertSITimeout(siApp.ExecutionTimeoutMilliSeconds)
 	if time.Duration(0) == placeholderTimeout {

diff --git a/pkg/scheduler/partition.go b/pkg/scheduler/partition.go
@@ -1491,8 +1491,8 @@ func (pc *PartitionContext) hasUnlimitedNode() bool {
 }
 
 func (pc *PartitionContext) addRejectedApplication(rejectedApplication *objects.Application,rejectionMessage string) error {
-	pc.Lock()
-	pc.Unlock()
+	rejectedApplication.GetRejectionMessage()
+	rejectedApplication.GetRejectionMessage()
 	if err := rejectedApplication.HandleApplicationEvent(objects.RejectApplication); err != nil {
 		log.Logger().Warn("Application state not changed to Rejected",
 			zap.String("currentState", rejectedApplication.CurrentState()),