Feature/pop off on drag right #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w controllers but the first when the user drags the entire stack to the right
…ollers by dragging to the right (pop all, all but first, or top)
… right to get view controllers to pop off instead of a magic number
…is dragging stackedViewDidStartDragging: - Called when user starts dragging the stack stackedViewDidStopDragging: - Called when user stops dragging the stack stackedViewWillPopViewControllers: - Called when the user has dragged the entire stack far enough right that it will trigger the pop off when released (enablePopOffOnDragRight must be set to YES) stackedViewWillNotPopViewControllers: - Called if the user returns the stack far enough left so that it will no longer trigger the pop off when released (enablePopOffOnDragRight must be set to YES)
…ght feature. The example now uses the "pop view controller when dragged to the right" feature; it also handles the delegate methods to provide visual feedback to the user similar to the twitter app. The example uses the SVPopOptionAllButFirst type (functions the same as twitter); this can be changed by changing the value of the popOffType property of the stack controller instance.
…iewControllers that will (or will no longer be) popped.
… so that it doesn't show the animation when no view controllers will be popped off (only one controller in the stack).
…the right so that it doesn't mess up if not starting with a floatIndex of 0.0 (can often start from floatIndex 0.5)
… all cases where floatIndex < 0.5 instead of == 0.0
…f the first view controller in the stack instead of the users drag; makes it much more consistent in behaviour
|
Thanks! You need merge the upstream changes first, before I can merge this. |
|
how? i am not a github expert.... |
|
i've done something...check it out! ;) |
…ure/pop_off_on_drag_right drag to pop
|
It's a little trickier than that. You need to pull from my master, then merge all the changes that happened since those commits. |
|
O.o i think a lot of scary commands for a git noob... :( give me a tutorial to follow step by step or commands to exec... :) |
|
this feature is really good, can we manage to get it merged back to master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.