[ANCHOR-708][PD] Add sep24-reference-ui helm charts #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiahuiWho
changed the title
philipliu
reviewed
Feb 12, 2025
| name: sep24-reference-ui-config | ||
| namespace: {{ .Values.namespace }} | ||
| data: | ||
| BUSINESS_SERVER_ENDPOINT: "http://localhost:8091" |
There was a problem hiding this comment.
This should use the Kubernetes hostname of the reference server. It looks like [srv-name].[namespace].svc.cluster.local.
There was a problem hiding this comment.
The k8s hostname (only accessible inside the cluster) is not reachable because the ui is a client-side app running in the browser and trying accessing it via localhost:3000 (which is my local machine, not inside the cluster).
I will go ahead try switch ingress to NodePort
There was a problem hiding this comment.
Oh right, this should be the hostname then. It should be parameterized to whatever was set in the ingress.
sep24-ref-ui: 1. use ui docker image instead of build local 2. rename ref to ui under values.services 3. move ingress host to values.yaml 4. adding missing annotations and labels 5. move businessServerEndpoint to value file reference-server: 1. move ingress host to values.yaml 2. Adding missing annotations and labels
philipliu
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
./gradlew testTest with demo wallet and transaction complete