Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign with Ledger: Better error message when app not selected #1220

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Sign with Ledger: Better error message when app not selected #1220

merged 1 commit into from
Jan 8, 2025

Conversation

quietbits
Copy link
Contributor

@quietbits quietbits commented Jan 7, 2025 •
edited
Loading

Before

image

After

image

@quietbits quietbits linked an issue Jan 7, 2025 that may be closed by this pull request
Better handle ledger UNKNOWN error message #1212
Closed
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1220.previews.kube001.services.stellar-ops.com/

@quietbits quietbits requested a review from jeesunikim January 7, 2025 20:00
jeesunikim
jeesunikim approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@jeesunikim jeesunikim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@quietbits quietbits merged commit 8f1546e into main Jan 8, 2025
5 checks passed
@quietbits quietbits deleted the sign-txn-ledger-msg branch January 8, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeesunikim jeesunikim jeesunikim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better handle ledger UNKNOWN error message
3 participants
@quietbits @stellar-jenkins @jeesunikim