Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guide for extending a persistent entry and contract using the javascript sdk #1163

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Mackenzie-OO7
Copy link
Contributor

closes #610

@briwylde08
Copy link
Contributor

Heya @Mackenzie-OO7! Thank you for another great submission. Apologies for the delay in review, we'll get to this ASAP!

@briwylde08 briwylde08 requested review from carstenjacobsen and anataliocs and removed request for ElliotFriend January 21, 2025 19:16
anataliocs

This comment was marked as outdated.

@briwylde08
Copy link
Contributor

Hi @Mackenzie-OO7 - thanks again so much for your contributions! Have you been able to look at the feedback yet?

Copy link
Contributor

@anataliocs anataliocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review:

https://developers.stellar.org/docs/learn/encyclopedia/storage/state-archival#extendfootprintttlop

Operation.extendFootprintTtl The Read-only set needs to contain the ledger key and the read/write section needs to be empty

ExtendFootprintTTLOp is a Soroban operation that will extend the live until ledger of the entries specified in the read-only set of the footprint. The read-write set must be empty.

@Mackenzie-OO7
Copy link
Contributor Author

Hi @Mackenzie-OO7 - thanks again so much for your contributions! Have you been able to look at the feedback yet?

hi! somehow I missed this, but I see there's new feedback now and I'll get to it. thanks for the reminder.

@Mackenzie-OO7
Copy link
Contributor Author

apologies for the delay, I had some issues with my machine, but I’ve sorted that out now.

@briwylde08
Copy link
Contributor

Hi @Mackenzie-OO7! Just checking, is this ready for re-review?

@Mackenzie-OO7
Copy link
Contributor Author

Mackenzie-OO7 commented Mar 4, 2025

Hi @Mackenzie-OO7! Just checking, is this ready for re-review?

Yes it is

@Mackenzie-OO7
Copy link
Contributor Author

@Shaptic thanks for reviewing! i've made the suggested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a guide on how to extend a persistent entry or contract using the JavaScript SDK
4 participants