Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install libdbus-1-dev for cli #109

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

elizabethengelman
Copy link
Contributor

@elizabethengelman elizabethengelman commented Dec 5, 2024

this is a dependency for keyring, which we're using for signing with keychains/secure store

related to stellar/stellar-cli#1481

related cli pr: stellar/stellar-cli#1703

this is a dependency for keyring, which we're using for signing with
keychains/secure store
Dockerfile.soroban-cli Outdated Show resolved Hide resolved
Co-authored-by: Willem Wyndham <[email protected]>
@sagpatil sagpatil requested a review from Ifropc January 9, 2025 21:18
@sreuland sreuland merged commit 5df600c into stellar:master Jan 9, 2025
3 checks passed
@sreuland
Copy link
Contributor

does this library need to be on the system path at cli runtime? if so, then need to add the dep to the main image - https://github.com/stellar/system-test/blob/master/Dockerfile#L30

@elizabethengelman
Copy link
Contributor Author

elizabethengelman commented Jan 27, 2025

does this library need to be on the system path at cli runtime? if so, then need to add the dep to the main image - https://github.com/stellar/system-test/blob/master/Dockerfile#L30

@sreuland good call. I'm looking into this, and was able to repro the issue locally using act. I found that adding this dependency to the quickstart image also worked to fix the issue. stellar/quickstart#662

I'm testing out adding it to the system path right now, like you suggested right now. That may be a better place to fix this specific issue.

@elizabethengelman
Copy link
Contributor Author

@sreuland just opened a PR with the fix you suggested: #118

Not 100% sure, but I think that we will likely still also want to include these libraries in the quickstart image as well, so stellar/quickstart#662 is also probably still relevant. Does that make sense to you @leighmcculloch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants