-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scala generation support. #32
base: master
Are you sure you want to change the base?
Conversation
Thanks Nate. This is looking good. After running rspec I attempted to compile the results. There were 2 compilation errors & also the warning about classes overwriting on case-insensitive filesystems (I think we agreed this was not a dealbreaker, but I was under the impression that modern Windows systems are case-sensitive - however this doesn't seem to be the case. We probably should avoid case-insensitive class filename collisions).
|
@bartekn The ideal testing I have in mind would run binary encoded events through a testing program that would be provided per language. (May not be automated via travis - but would be easily runnable offline.) The idea being that one could convert binary -> decoded message in the new language -> and back to binary. The round-trip at least guarantees encoding/decoding is symmetric. Having a nice suite of prepared messages is convenient for future language integration. |
@nbauernfeind yeah, I think it makes sense. We could create a testing set of XDR definitions (including all standard types) and make sure these are encoded to the same binary form (and the other way: from binary to data) using a different implementations. This shouldn't be hard to do and will provide a good coverage. If you want to work on this, please do it in a separate PR. |
It would greatly simplify stellar's scala sdk (see Synesso/scala-stellar-sdk#13) to use an interface that more natively integrated with Scala than the Java API.
This change adds full generation support for scala. It was tested by generating source code for stellar-core's XDR classes and compiling them with scalac. More thorough testing is TBD.
This is a portion of my contribution for the Stellar Build Challenge 7.