Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/KAD-3949 #643

Merged
merged 1 commit into from
Jan 7, 2025
Merged

bugfix/KAD-3949 #643

merged 1 commit into from
Jan 7, 2025

Conversation

gilbert-hernandez
Copy link
Contributor

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-3949
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

@gilbert-hernandez
Copy link
Contributor Author

I opted to add the $attributes['textShadow'] array if it was empty instead of messing with the other conditionals. This fix ensures that the textShadow attribute exists and has values if the default values aren't changed and the option for the text shadow is enabled.

@oakesjosh oakesjosh merged commit f4a69a3 into master Jan 7, 2025
25 checks passed
@oakesjosh oakesjosh deleted the bugfix/KAD-3949 branch January 7, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants