Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use our own build of json-merge lib #854

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

bobeal
Copy link
Member

@bobeal bobeal commented Feb 9, 2023

- currently includes an outdated and insecure version of org.json:json lib
- did a PR in 08/2022 but got no response so far (savvasdalkitsis/json-merge#2)
- so forked and published the lib on Jitpack (https://jitpack.io/#stellio-hub/json-merge)
@bobeal bobeal requested a review from gpoujol February 9, 2023 19:41
@github-actions github-actions bot added the chore Maintenance task label Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Test Results

655 tests  ±0   655 ✔️ ±0   1m 19s ⏱️ +29s
  48 suites ±0       0 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 1861bbd. ± Comparison against base commit 35f8196.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bobeal bobeal merged commit 24b2cfa into develop Feb 10, 2023
@bobeal bobeal deleted the chore/upgrade-json-merge-lib branch February 10, 2023 07:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants