Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update EntitySelector (was EntityInfo) in Subscription API… #895

Conversation

gpoujol
Copy link
Contributor

@gpoujol gpoujol commented Mar 22, 2023

No description provided.

@github-actions github-actions bot added the feature New feature or request label Mar 22, 2023
@gpoujol gpoujol changed the title feat(893): Update EntitySelector (was EntityInfo) in Subscription API… feat: Update EntitySelector (was EntityInfo) in Subscription API… Mar 22, 2023
@gpoujol gpoujol added the subscription Relates to subscription API label Mar 22, 2023
@github-actions
Copy link
Contributor

Test Results

1 tests   1 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit 03810d9.

@bobeal
Copy link
Member

bobeal commented Mar 22, 2023

I thought it was not ready?

@gpoujol
Copy link
Contributor Author

gpoujol commented Mar 22, 2023

I thought it was not ready?

I just took over what had been done on the other PR on this part

@bobeal
Copy link
Member

bobeal commented Mar 22, 2023

I thought it was not ready?

I just took over what had been done on the other PR on this part

yes, in the branch but don't do a PR

@gpoujol
Copy link
Contributor Author

gpoujol commented Mar 22, 2023

I thought it was not ready?

I just took over what had been done on the other PR on this part

yes, in the branch but don't do a PR

You told me Split it into 2 parts (2 issues and 2 PRs)

@bobeal
Copy link
Member

bobeal commented Mar 22, 2023

I thought it was not ready?

I just took over what had been done on the other PR on this part

yes, in the branch but don't do a PR

You told me Split it into 2 parts (2 issues and 2 PRs)

Don't trust everything I say (what's more, when it does not make sense) :)

(or create one but in Draft state)

@gpoujol gpoujol marked this pull request as draft March 22, 2023 14:07
Base automatically changed from feature/892-implement-entity-type-selection-language-for-search-service to develop March 22, 2023 14:36
@bobeal bobeal closed this Nov 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
@bobeal bobeal deleted the feature/893-update-EntitySelector-(was-EntityInfo)-in-Subscription-API-to-handle-multi-typing branch November 19, 2023 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request ngsild-1.5.1 subscription Relates to subscription API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update EntitySelector (was EntityInfo) in Subscription API to handle multi-typing
2 participants