Fix DomainEvents memory leak risk #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using cls-hooked(forked from continuation-local-storage), change the DomainEvents from singleton to normal class, but also with a factory method `create`. `create` will find registered DomainEvents instance from the current cls context, if not, a new instance will be returned and register it to the current context.
|
This change violates the principle of separation of concerns, SoC for short. However, a static class is a really bad idea for DomainEvents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
cls-hooked(forked from continuation-local-storage), change theDomainEvents from singleton to normal class, but also with a factory
method
create.createwill find registered DomainEvents instance from the current clscontext, if not, a new instance will be returned and register it to the
current context.