Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keeping the original song file #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wc2184
Copy link

@wc2184 wc2184 commented Jul 5, 2024

Since we're fetching the audio from youtube-dl, I just wanted to keep the original song as well, but currently you just run demucs and delete the original song file.

I simply copy the original song ('yt-audio) (from the temp directory) to the output directory, rename it to original, call ffmpeg on it to convert it to .wav (or mp3 depending on your preferences) with a sample rate of 44.1k which the same sample rate of the stems of demucs

tldr; add the original song to the output folder, convert it to wav/mp3

.wav

CleanShot 2024-07-05 at 15 14 35@2x

.mp3

CleanShot 2024-07-05 at 15 13 51@2x

@wc2184
Copy link
Author

wc2184 commented Jul 5, 2024

Would you like to put this as a toggle instead of default? It does increase the time of processing by quite a bit, let me know if you would like for me to add it as a checkbox in the Preferences setting and leave it unticked it by default.

Something like this (this feature is not added in the PR, just my mockup):

CleanShot 2024-07-05 at 15 12 06@2x

@wc2184 wc2184 changed the title keep the original song file + convert > wav or mp3 keeping the original song file Jul 5, 2024
@iffyloop
Copy link
Member

iffyloop commented Jul 12, 2024

@wc2184 Thanks for the PR! Sorry for my delayed reply, I'm actually looking into developing a new major version of StemRoller so the current (2.x) series is kind of in bugfix-only mode right now. I'd like to add this feature, but why does it increase the processing time by quite a bit? I think audio format conversion is usually pretty fast compared to the stem separation process. Do you need the file-type module? I thought ffmpeg could detect filetype automatically but I may be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants