Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair stencil-route-prompt (ask user for confirmation before navigation) #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Repair stencil-route-prompt (ask user for confirmation before navigation) #121

wants to merge 1 commit into from

Commits on Dec 10, 2020

  1. fix(): bind window as first param of getConfirmation 

    When `create***History` runs, `getUserConfirmation` defaults to the
`getConfirmation` function, which expects the global `window` object as
its first parameter.  However, it is later invoked without passing
`window`, probably because the signature for the user-defined flavor in
`CreateBrowserHistoryOptions` does not expect `window` to be passed.

The simple fix is to bind `window` to the default `getConfirmation`
function as its first parameter.
    Michael Speed Elder committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    6de5c7b View commit details
    Browse the repository at this point in the history