Code

FC43 Frame Writer and Improvements#142

Code

Open

grewek wants to merge 42 commits intostepfunc:iware/reviewstepfunc/rodbus:iware/reviewfrom grewek:feature/fc43-iprovements-newgrewek/rodbus:feature/fc43-iprovements-newCopy head branch name to clipboard

+406-111

Commits

Commits on Feb 26, 2024

• Merge remote-tracking branch 'origin/iware/review' into feature/fc43-temp

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  e8efaa6

  Copy full SHA for e8efaa6

• refactor(read_device_info_handler): change return type.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  5f4c64f

  Copy full SHA for 5f4c64f

• refactor(get_reply): store the data returned by the handler, add todo!()

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  9bf03e8

  Copy full SHA for 9bf03e8

Commits on Feb 27, 2024

• refactor(response): add option arg to callback, change return type.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  2324bde

  Copy full SHA for 2324bde

• refactor(ServerDeviceInfo): add derived traits to struct.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  232d8e2

  Copy full SHA for 232d8e2

• refactor(response_message_count): comment out old code for now

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  a475ec9

  Copy full SHA for a475ec9

• refactor(integration_tests): change response of integration tests.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  38b8a8f

  Copy full SHA for 38b8a8f

• refactor(get_reply): do some calculations before passing the index on

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  cbfb469

  Copy full SHA for cbfb469

• refactor(server): testing how to pass slices from functions...

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  fedc5aa

  Copy full SHA for fedc5aa

• refactor(trait serialize): change the serialization of read device info

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  6d92494

  Copy full SHA for 6d92494

• refactor(server): remove import and use the direct path of the enum.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  babd8be

  Copy full SHA for babd8be

• chore(read device identification): rustfmt

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  6f4e62d

  Copy full SHA for 6f4e62d

• refactor(frame): add FrameRecords struct and change serialize trait.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  274399f

  Copy full SHA for 274399f

• refactor(serialize trait): add recorder into serialize trait

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  3c144b3

  Copy full SHA for 3c144b3

• refactor(serialize): pass none where no recorder is necessary

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  a5979ab

  Copy full SHA for a5979ab

• chore(grammar): remove double "the" from doc comment

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  5d09fb2

  Copy full SHA for 5d09fb2

Commits on Feb 28, 2024

• tests(frame): fix the frame tests by adding the now necessary frame rec.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  5011f28

  Copy full SHA for 5011f28

• refactor(frame_recorder): Improve the API of the FrameRecorder.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  6fc31f5

  Copy full SHA for 6fc31f5

• feat(RecorderError): add a new error type for the frame recorder

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  8b085f2

  Copy full SHA for 8b085f2

• refactor(server_device_info): add read_device_code back into the struct

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  5b6c4e0

  Copy full SHA for 5b6c4e0

• refactor(server_device_info): add read_device_code field.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  69ea1b3

  Copy full SHA for 69ea1b3

• refactor(serialize): change usage of FrameRecorder API

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  1b401bf

  Copy full SHA for 1b401bf

• refactor(server): temporary add field to returned dummy value.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  823cbff

  Copy full SHA for 823cbff

Commits on May 22, 2024

• refactor(handler): add current_object_id to ReadDeviceInfo struct

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  899355c

  Copy full SHA for 899355c

• refactor(serialize): object by object serialization for FC43

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  02ebb9a

  Copy full SHA for 02ebb9a

• feat(error): add frame record errors to the InternalError enum

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  c097976

  Copy full SHA for c097976

• refactor(frame): get rid of the unwraps in the fill_record method

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  3df08a3

  Copy full SHA for 3df08a3

• feat(frame): add handling of non-empty frame recorders before sending

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  488e085

  Copy full SHA for 488e085

• refactor(request): remove unnecessary stuff from the way fc43 is handled

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  1cfe7b9

  Copy full SHA for 1cfe7b9

• test(integration_tests): change the code that generates the response

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  76e5e1d

  Copy full SHA for 76e5e1d

• feat(ffi): add FrameRecorderNotEmpty conversion into InternalError

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  049e7ea

  Copy full SHA for 049e7ea

• refactor(message): make the FrameRecorder argument invisible.

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  d338561

  Copy full SHA for d338561

• chore(read_device_ident): cargo fmt improvements

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  e6a817c

  Copy full SHA for e6a817c

• refactor(frame): remove unnecessary imports, unnecessary clone, run fmt

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  9c7b75f

  Copy full SHA for 9c7b75f

• refactor(serialize): remove unnecessary imports, make records invisible

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  084197c

  Copy full SHA for 084197c

• chore(traits): cargo fmt formatting applied

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  7e355c6

  Copy full SHA for 7e355c6

• chore(frame): cargo fmt formatting applied

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  b26e1a4

  Copy full SHA for b26e1a4

• refactor(error): remove unnecessary import, apply cargo formatting

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  edcfc09

  Copy full SHA for edcfc09

• chore(request): apply cargo formatting

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  01196a8

  Copy full SHA for 01196a8

• refactor(response): remove unnecessary imports, apply cargo formatting

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  342edb4

  Copy full SHA for 342edb4

• chore(frame): apply cargo formatting

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  b032c00

  Copy full SHA for b032c00

• chore(e2e_read_device): remove commented code, apply cargo formatting

  

  Kay Grewe

  authored and

  Kay Grewe

  committed
  0ec01f4

  Copy full SHA for 0ec01f4