Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding get_query_function #667

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cedricboudinet
Copy link
Contributor

Hello
Here is a PR adding a function enabling one to read the modbus function of a query.
It can be useful for modbus server development.
If you are ok with it I can complete the docs as well.
Bests
Cedric

@cla-bot
Copy link

cla-bot bot commented Nov 10, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Cedric Boudinet.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 10, 2022

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

@mhei
Copy link
Contributor

mhei commented Nov 11, 2022

Usually open source development works that way, that you create a full PR, i.e. including documentation etc.
In your documentation, I would for example expect to find a description of your use case for this new function - at the moment, you only described it roughly.

@cla-bot
Copy link

cla-bot bot commented Nov 15, 2022

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

@cla-bot
Copy link

cla-bot bot commented Nov 15, 2022

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

@cla-bot cla-bot bot added the cla-signed label Dec 6, 2022
@cedricboudinet
Copy link
Contributor Author

Dear @stephane
Could this PR be merged as well?
Bests
Cedric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants