Fix float32 encoding/decoding (#665, #694, #757) #770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit reverts the problematic patch "Fix float endianness issue on big endian architecture." (but keeps the good parts of it).
This reverts commit 49af73d.
The test suite is updated to use correct processor-endianess when defining comparison values. Then, the getter functions and setter functions are aligned to be consistent regarding the memory layout.
Documentation about the memory layout in modbus_mapping_t has been added (see #757).
Code has been tested against Modbus poll and with mbpoll using an old version of libmodus (3.1.8) prior to the faulty commit.