fix: add serviceName to grpc-js client constructor type (#980)

* fix: add serviceName to grpc-js client constructor type * Re-codegen. --------- Co-authored-by: Stephen Haberman <[email protected]>
stephenh · Dec 26, 2023 · 2c6682d · 2c6682d
1 parent 4c94318
commit 2c6682d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 0 deletions.
diff --git a/integration/grpc-js-use-date-false/grpc-js-use-date-false.ts b/integration/grpc-js-use-date-false/grpc-js-use-date-false.ts
@@ -136,6 +136,7 @@ export interface TestClient extends Client {
 export const TestClient = makeGenericClientConstructor(TestService, "simple.Test") as unknown as {
   new (address: string, credentials: ChannelCredentials, options?: Partial<ClientOptions>): TestClient;
   service: typeof TestService;
+  serviceName: string;
 };
 
 type Builtin = Date | Function | Uint8Array | string | number | boolean | undefined;

diff --git a/integration/grpc-js-use-date-string/grpc-js-use-date-string.ts b/integration/grpc-js-use-date-string/grpc-js-use-date-string.ts
@@ -134,6 +134,7 @@ export interface TestClient extends Client {
 export const TestClient = makeGenericClientConstructor(TestService, "simple.Test") as unknown as {
   new (address: string, credentials: ChannelCredentials, options?: Partial<ClientOptions>): TestClient;
   service: typeof TestService;
+  serviceName: string;
 };
 
 type Builtin = Date | Function | Uint8Array | string | number | boolean | undefined;

diff --git a/integration/grpc-js-use-date-true/grpc-js-use-date-true.ts b/integration/grpc-js-use-date-true/grpc-js-use-date-true.ts
@@ -134,6 +134,7 @@ export interface TestClient extends Client {
 export const TestClient = makeGenericClientConstructor(TestService, "simple.Test") as unknown as {
   new (address: string, credentials: ChannelCredentials, options?: Partial<ClientOptions>): TestClient;
   service: typeof TestService;
+  serviceName: string;
 };
 
 type Builtin = Date | Function | Uint8Array | string | number | boolean | undefined;

diff --git a/integration/grpc-js/simple.ts b/integration/grpc-js/simple.ts
@@ -631,6 +631,7 @@ export interface TestClient extends Client {
 export const TestClient = makeGenericClientConstructor(TestService, "simple.Test") as unknown as {
   new (address: string, credentials: ChannelCredentials, options?: Partial<ClientOptions>): TestClient;
   service: typeof TestService;
+  serviceName: string;
 };
 
 type Builtin = Date | Function | Uint8Array | string | number | boolean | undefined;

diff --git a/src/generate-grpc-js.ts b/src/generate-grpc-js.ts
@@ -238,6 +238,7 @@ function generateClientConstructor(fileDesc: FileDescriptorProto, serviceDesc: S
         options?: Partial<${ClientOptions}>,
       ): ${serviceDesc.name}Client;
       service: typeof ${serviceDesc.name}Service;
+      serviceName: string;
     }
   `;
 }