Skip to content

Disable logging for requests aborted due to skipThirdPartyRequests, for #242 #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable logging for requests aborted due to skipThirdPartyRequests, for #242 #436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/puppeteer_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ const skipThirdPartyRequests = async opt => {
if (request.url().startsWith(basePath)) {
request.continue();
} else {
request.abort();
request.abort('blockedbyclient');
}
});
};

/**
* @param {{page: Page, options: {sourceMaps: boolean}, route: string, onError: ?function }} opt
* @param {{page: Page, options: {sourceMaps: boolean}, route: string, onError: ?function, basePath: string }} opt
* @return {void}
*/
const enableLogging = opt => {
Expand All @@ -44,6 +44,9 @@ const enableLogging = opt => {
Promise.all(msg.args().map(errorToString)).then(args =>
console.log(`💬 console.log at ${route}:`, ...args)
);
} else if (text.includes('ERR_BLOCKED_BY_CLIENT') && options.skipThirdPartyRequests === true &&
msg.location() && !msg.location().url.startsWith(basePath)) {
// pass -- do not log errors from requests blocked by skipThirdPartyRequests
} else {
console.log(`️️️💬 console.log at ${route}:`, text);
}
Expand Down Expand Up @@ -232,7 +235,8 @@ const crawl = async opt => {
onError: () => {
shuttingDown = true;
},
sourcemapStore
sourcemapStore,
basePath
});
beforeFetch && beforeFetch({ page, route });
await page.setUserAgent(options.userAgent);
Expand Down