BugFix for GPSReader Initialization #675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the generator
self.gnss_getterwas being recreated on each iteration of the while loop. As a result,gpsd_data = next(self.gnss_getter)was called only once per loop iteration, leading to unnecessary computational overhead. Additionally, after testing locally, on every new generator creation inside thewhileloop, the first message received was consistently aSKYmessage, causing the initialization step to fail. (I am not pretty sure why it was always beSKYmessages). After debugging and testing, moving the generator creation outside thewhileloop resolved these issues. Please let me know if there are any questions or further improvements needed.