RSDK-9098: test go in module generation test (viamrobotics#4504)

stevebriskin · Nov 1, 2024 · 9c30b69 · 9c30b69
1 parent a34352b
commit 9c30b69
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/test-module-generation.yml b/.github/workflows/test-module-generation.yml
@@ -10,6 +10,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
+        language: ["python", "go"]
         resource:
           [
             { subtype: "arm", type: "component" },
@@ -46,7 +47,7 @@ jobs:
           go-version-file: go.mod
 
       - name: Run module generator
-        run: go run ./cli/viam --debug module generate --resource-subtype "${{ matrix.resource.subtype }}" --resource-type "${{ matrix.resource.type }}"
+        run: go run ./cli/viam --debug module generate --resource-subtype "${{ matrix.resource.subtype }}" --resource-type "${{ matrix.resource.type }}" --language "${{ matrix.language }}"
 
       - name: Run module
         run: |

diff --git a/cli/app.go b/cli/app.go
@@ -42,6 +42,7 @@ const (
 	apiKeyCreateFlagName = "name"
 
 	moduleFlagName            = "name"
+	moduleFlagLanguage        = "language"
 	moduleFlagPublicNamespace = "public-namespace"
 	moduleFlagPath            = "module"
 	moduleFlagVersion         = "version"
@@ -1496,6 +1497,11 @@ After creation, use 'viam module update' to push your new module to app.viam.com
 					Name:  "generate",
 					Usage: "generate a new modular resource via prompts",
 					Flags: []cli.Flag{
+						&cli.StringFlag{
+							Name:  moduleFlagLanguage,
+							Usage: "language to use for module",
+							Value: "python",
+						},
 						&cli.StringFlag{
 							Name:  moduleFlagResourceType,
 							Usage: "resource type to use in module",

diff --git a/cli/module_generate.go b/cli/module_generate.go
@@ -65,7 +65,7 @@ func (c *viamClient) generateModuleAction(cCtx *cli.Context) error {
 			ModuleName:       "my-module",
 			IsPublic:         false,
 			Namespace:        "my-org",
-			Language:         python,
+			Language:         cCtx.String(moduleFlagLanguage),
 			Resource:         resourceSubtype + " " + resourceType,
 			ResourceType:     resourceType,
 			ResourceSubtype:  resourceSubtype,