-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding request extra to support value like "nvidia.com/gpu: 1" #900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @pjeon2. I've added a couple of generic review comments which would need addressing before this PR could be tested.
However that said I'm not sure if the explicit capacity.resources.cpu
& capacity.resources.memory
are required as capacity.resources
could be untyped and directly used with toYaml
. What do you think?
Yeah, I think converting entire |
@stevehipwell I resolved all your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested an update to the value comment for consistency; you'll need to re-run helm-docs
after changing this.
Could you also update the changelog under the unreleased section.
Added changelog as recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Current helm chart only supports
cpu
andmemory
, so I would like to add extra fieldFor example, I need to add below values
To support the above values, I added
resources.extra
fieldCloses #901.