Make text tool label more configurable via ACEDrawingViewDelegate; fix several bugs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelandeyasana
changed the title
TheDom
approved these changes
Jul 11, 2018
ACEDrawingView/ACEDrawingLabelView.m
Outdated
|
|
||
| _globalInsets = CGSizeMake(12, 12); | ||
| _closeButtonOffset = CGPointMake(0, 0); | ||
| _rotateButtonOffset = CGPointMake(0, 0); |
There was a problem hiding this comment.
[nit] We could use CGPointZero
| _labelView.textColor = self.lineColor; | ||
| _labelView.fontName = self.drawingView.draggableTextFontName ?: [UIFont systemFontOfSize:_labelView.fontSize].fontName; |
There was a problem hiding this comment.
Out of curiosity: Is there a special reason why the order was swapped?
There was a problem hiding this comment.
Honestly just aesthetics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of ACEDrawingView#96 for internal review by Asana.
Some people (i.e. me) want to customize several aspects of ACEDrawingLabelView which are not currently exposed to users of the framework. This PR makes the changes necessary to enable that customization.
ACEDrawingLabelViewhas new configurable properties that replace previously hard-coded values:[close|rotate]ButtonOffset[close|rotate]ButtonSize[close|rotate]Buttonshadow[Color|Opacity|Radius|Offset]ACEDrawingViewDelegatehas a new optional method which allows the delegate to configure those properties before the label is displayed:[delegate labelViewNeedsConfiguration:label]