Improved handling of failed git editor check

stevenengler · Jun 23, 2024 · 99d687e · 99d687e
1 parent 6b67af2
commit 99d687e
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/src/util.rs b/src/util.rs
@@ -307,14 +307,16 @@ pub fn editor_cmd() -> impl Iterator<Item = impl AsRef<OsStr>> + Clone {
             .arg("core.editor")
             .output()
         {
-            let mut output = output.stdout;
-            // the last byte should be a nul
-            assert_eq!(Some(0), output.pop());
-
-            if !output.is_empty() {
-                let cmd = split_whitespace(&output);
-                if !cmd.is_empty() {
-                    return cmd;
+            if output.status.success() {
+                let mut output = output.stdout;
+                // the last byte should be a nul
+                assert!(matches!(output.pop(), Some(0) | None));
+
+                if !output.is_empty() {
+                    let cmd = split_whitespace(&output);
+                    if !cmd.is_empty() {
+                        return cmd;
+                    }
                 }
             }
         }