Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2C Wrapper + Controller #36

Merged
merged 4 commits into from
Dec 4, 2024
Merged

I2C Wrapper + Controller #36

merged 4 commits into from
Dec 4, 2024

Conversation

echavemann
Copy link
Collaborator

@echavemann echavemann commented Dec 1, 2024

Mirror of the early work from Lab 6 + Adding I2C Controller

@echavemann echavemann self-assigned this Dec 1, 2024
@echavemann echavemann force-pushed the echavemann/aidan-i2c branch 2 times, most recently from 462b6c3 to 0985f9f Compare December 1, 2024 19:53
@echavemann echavemann force-pushed the echavemann/aidan-i2c branch from 0985f9f to 5b8235b Compare December 1, 2024 19:56
@echavemann echavemann marked this pull request as ready for review December 1, 2024 20:04
@echavemann echavemann force-pushed the echavemann/aidan-i2c branch from e0fd699 to 55571b1 Compare December 1, 2024 20:29
@echavemann echavemann marked this pull request as draft December 1, 2024 22:53
@echavemann
Copy link
Collaborator Author

TODO: include the i2c manager class in this so we don't have to deal with it in userland

src/hal/i2c_controller.cpp Outdated Show resolved Hide resolved
@echavemann echavemann force-pushed the echavemann/aidan-i2c branch from a31ef7f to 808fa6b Compare December 2, 2024 20:18
@echavemann echavemann changed the title I2C Wrapper I2C Wrapper + Controller Dec 2, 2024
@echavemann echavemann marked this pull request as ready for review December 2, 2024 20:19
src/hal/i2c_controller.cpp Outdated Show resolved Hide resolved
include/hal/i2c_controller.hpp Outdated Show resolved Hide resolved
src/hal/i2c_wrapper.cpp Show resolved Hide resolved
@echavemann echavemann force-pushed the echavemann/aidan-i2c branch from cce2572 to 8edac30 Compare December 2, 2024 21:04
Copy link
Owner

@stevenewald stevenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, change what u like im fine w it

@echavemann echavemann merged commit 2b28efe into main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants