implemented designs for application process section #231
Conversation
|
Have to fix merge issues, will be done later. |
|
Can you add your components to a ForStudents directory in the components folder? Can you also group the StudentsHero component into it as well and update the imports? |
|
Small comment for future reference. You are supposed to name your branch in the following format:
|
|
|
||
| export default function ApplicationProcess({ comp }) { | ||
| return ( | ||
| <section className="flex flex-col items-center px-12 pb-12 max-lg:px-12 max-md:w-full max-md:px-4"> |
There was a problem hiding this comment.
nit: The top padding of the application changes does not correspond. to the paddings elsewhere in the /students page.
Try to fix the padding, so that they are both the same. You will need to change the top padding in this component.
There was a problem hiding this comment.
I think for the top section the whitespace is due to the padding of another component, I think for this PR you can leave it as is @dersual
There was a problem hiding this comment.
If you are talking about the weird spacing between the Our Teams and Application Process sections, it's because the component/element before it has a large padding at the bottom. Although I didn't make that component, would you like me to adjust the padding?
There was a problem hiding this comment.
I pushed a commit fixing the bottom padding of the abovementioned component, though the extra space can also be attributed to its weird height. I talked to Christian yesterday and it should be okay for now, just wanted to check if the spacing is also okay for you now.
* created project timeline component and added it to NPO jsx * took out borders when smaller screen
* left side good; overlapping boxes only work on computer screen * hopefully fixed responsiveness issues, adjusts to text * ran prettier * fixed sizing problem, testimonial now drops below text on smaller screens * added docs folder to assets * updated button with download component (all others still work on my device), linked pdf * fixed prettier issue --------- Co-authored-by: Caposto <[email protected]>
|
|
||
| export default function ApplicationProcess({ comp }) { | ||
| return ( | ||
| <section className="flex flex-col items-center px-12 pb-12 max-lg:px-12 max-md:w-full max-md:px-4"> |
There was a problem hiding this comment.
I think for the top section the whitespace is due to the padding of another component, I think for this PR you can leave it as is @dersual
#216
Implemented new designs for the application process section and internal teams sections.
