Skip to content

Commit

Permalink
Resolve on NeoForge pcal43#260 ed25519 keys are not support in fasbac…
Browse files Browse the repository at this point in the history
…k-forge

At-least I believe it does. Uploading was failing with a jgit error aboud failing to negotiate the algorithm.
Uploading to gitea and github now work after this change, which indicates to me that this issue is resolved.

All that's been changed is neoforge dependencies have been updated to reflect the dependencies in the fabric version.
  • Loading branch information
stewi1014 committed Nov 19, 2024
1 parent 39389c7 commit 98f9e92
Showing 1 changed file with 17 additions and 6 deletions.
23 changes: 17 additions & 6 deletions neoforge/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,25 @@ dependencies {
forgeRuntimeLibrary implementation("org.eclipse.jgit:org.eclipse.jgit:${project.jgit_version}") { transitive = false }
shadowCommon("org.eclipse.jgit:org.eclipse.jgit:${project.jgit_version}") { transitive = false }

forgeRuntimeLibrary runtimeOnly("org.eclipse.jgit:org.eclipse.jgit.ssh.jsch:${project.jgit_version}") { transitive = false; }
shadowCommon("org.eclipse.jgit:org.eclipse.jgit.ssh.jsch:${project.jgit_version}") { transitive = false }

forgeRuntimeLibrary runtimeOnly('com.jcraft:jsch:0.1.55')
shadowCommon('com.jcraft:jsch:0.1.55')

forgeRuntimeLibrary runtimeOnly("com.googlecode.javaewah:JavaEWAH:${project.JavaEWAH_version}") { transitive = false }
shadowCommon("com.googlecode.javaewah:JavaEWAH:${project.JavaEWAH_version}") { transitive = false }

// https://mvnrepository.com/artifact/org.eclipse.jgit/org.eclipse.jgit.ssh.apache
forgeRuntimeLibrary runtimeOnly("org.eclipse.jgit:org.eclipse.jgit.ssh.apache:${project.jgit_version}") { transitive = false }
shadowCommon("org.eclipse.jgit:org.eclipse.jgit.ssh.apache:${project.jgit_version}") { transitive = false }

// https://mvnrepository.com/artifact/org.apache.sshd/sshd-core
forgeRuntimeLibrary runtimeOnly("org.apache.sshd:sshd-core:${project.apache_sshd_version}") { transitive = false }
shadowCommon("org.apache.sshd:sshd-core:${project.apache_sshd_version}") { transitive = false }

// https://mvnrepository.com/artifact/org.apache.sshd/sshd-common
forgeRuntimeLibrary runtimeOnly("org.apache.sshd:sshd-common:${project.apache_sshd_version}") { transitive = false }
shadowCommon("org.apache.sshd:sshd-common:${project.apache_sshd_version}") { transitive = false }

// this enables ed25519 support in apache_sshd
// https://github.com/apache/mina-sshd/blob/dfa109b7b535d64e8ee395ddd0419e7696fb24ee/docs/dependencies.md
forgeRuntimeLibrary runtimeOnly("net.i2p.crypto:eddsa:${project.eddsa_version}") { transitive = false }
shadowCommon("net.i2p.crypto:eddsa:${project.eddsa_version}") { transitive = false }
}

processResources {
Expand Down

0 comments on commit 98f9e92

Please sign in to comment.