Allow to take arbitrary socket instead of address to estaplish connexion to proxy #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lack actual way of creating such struct
|
I think this is ready, but the CI is failing and I can't figure out why. Any insight is welcome. |
sticnarf
reviewed
Jul 14, 2020
There was a problem hiding this comment.
The code looks good to me. But you'd better reformat the project with the nightly toolchain (some settings in .rustfmt.toml are not available on stable).
I think the CI failure is caused by concurrent tests. --test-threads 1 may help. You can add it to tests/integration_tests.sh and try again.
sticnarf
approved these changes
Jul 15, 2020
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at solving both #5 and #19.
Most code is here, but it lacks documentation, tests, and an example.
This does break compatibility as some types that were fixed are now parametrized, however I've mostly kept previous interface so that changes are actually minimal.