fix: xadd inconsistency with redis implementation #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ullumullu
changed the title
This commit aligns id generation with the official "specification/docu": > Both quantities are 64-bit numbers. When an ID is auto-generated, the > first part is the Unix time in milliseconds of the Redis instance > generating the ID. The second part is just a sequence number and is > used in order to distinguish IDs generated in the same millisecond. Main motivation is that the current implementation was flawed when using capped streams by creating invalid ids (e.g. generating the same id twice) as well as re-using mocked tests and run them in an e2e fashion. Tests were added to cover the additional funcionality. Links: https://redis.io/commands/xadd/
ullumullu
force-pushed
the
improve_xadd_xread
branch
from
c2e2b81 to
d9150c9
Compare
|
Hi @stipsan any comments on this PR would be appreciated. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aligns id generation with the official "specification/docu":
Main motivation is that the current implementation was flawed when using capped streams by creating invalid ids (e.g. generating the same id twice) as well as re-using mocked tests and run them in an e2e fashion.
Tests were added to cover the enhanced functionality.
Links:
https://redis.io/commands/xadd/