revise: removes ordered_float from the f64 fields
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claymcleod
force-pushed
the
ordered-float
branch
from
74f6e95 to
5dcbb12
Compare
claymcleod
changed the title
ordered_floatordered_float from the f64 fields
peterhuene
approved these changes
Feb 7, 2025
claymcleod
force-pushed
the
ordered-float
branch
from
5dcbb12 to
7922319
Compare
Upon a closer look, [OpenAPI `double`s](https://swagger.io/docs/specification/v3_0/data-models/data-types/#numbers) don't have a strict definition of what they conform to, so I assume it's going to be IEEE-754. As such, the behavior of Rust to implement the `PartialEq`/`PartialOrd` without `Eq`/`Ord` should carry through here. Indeed, I see no evidence that something like `NaN == NaN` should hold.
claymcleod
force-pushed
the
ordered-float
branch
from
7922319 to
447772d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon a closer look, OpenAPI
doubles don't have a strict definition of what they conform to, so I assume it's going to be IEEE-754. As such, the behavior of Rust to implement thePartialEq/PartialOrdwithoutEq/Ordshould carry through here. Indeed, I see no evidence that something likeNaN == NaNshould hold.Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md(see"keep a changelog" for more information).