&Clocks instead of Clocks #39
changelog.yml
on: pull_request_target
Changelog check
4s
Annotations
14 warnings
Changelog check
The following actions uses node12 which is deprecated and will be forced to run on node16: Zomzog/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Changelog check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, Zomzog/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
usage of a legacy numeric constant:
src/timer/pwm_input.rs#L165
warning: usage of a legacy numeric constant
--> src/timer/pwm_input.rs:165:45
|
165 | let presc = clock / freq.saturating_mul(core::u16::MAX as u32 + 1);
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
165 | let presc = clock / freq.saturating_mul(u16::MAX as u32 + 1);
| ~~~~~~~~
|
usage of a legacy numeric constant:
src/timer/pwm_input.rs#L163
warning: usage of a legacy numeric constant
--> src/timer/pwm_input.rs:163:33
|
163 | return (core::u16::MAX, core::u16::MAX);
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
163 | return (core::u16::MAX, u16::MAX);
| ~~~~~~~~
|
usage of a legacy numeric constant:
src/timer/pwm_input.rs#L163
warning: usage of a legacy numeric constant
--> src/timer/pwm_input.rs:163:17
|
163 | return (core::u16::MAX, core::u16::MAX);
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
163 | return (u16::MAX, core::u16::MAX);
| ~~~~~~~~
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/spi.rs#L503
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/spi.rs:503:35
|
503 | let br = match SPI::clock(&clocks) / freq {
| ^^^^^^^ help: change this to: `clocks`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
importing legacy numeric constants:
src/qei.rs#L7
warning: importing legacy numeric constants
--> src/qei.rs:7:5
|
7 | use core::u16;
| ^^^^^^^^^
|
= help: remove this import
= note: then `u16::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
|
doc list item without indentation:
src/gpio.rs#L38
warning: doc list item without indentation
--> src/gpio.rs:38:5
|
38 | //! used if the [JTAG peripheral has been turned off](#accessing-pa15-pb3-and-pb14).
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
38 | //! used if the [JTAG peripheral has been turned off](#accessing-pa15-pb3-and-pb14).
| ++
|
doc list item without indentation:
src/gpio.rs#L36
warning: doc list item without indentation
--> src/gpio.rs:36:5
|
36 | //! mode. Can be used as an input in the `open` configuration
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
36 | //! mode. Can be used as an input in the `open` configuration
| ++
|
doc list item without indentation:
src/gpio.rs#L31
warning: doc list item without indentation
--> src/gpio.rs:31:5
|
31 | //! is connected
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
31 | //! is connected
| ++
|
doc list item without indentation:
src/gpio.rs#L29
warning: doc list item without indentation
--> src/gpio.rs:29:5
|
29 | //! is connected
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
29 | //! is connected
| ++
|
usage of a legacy numeric method:
src/adc.rs#L252
warning: usage of a legacy numeric method
--> src/adc.rs:252:45
|
252 | Align::Left => u16::max_value(),
| ^^^^^^^^^^^
...
548 | / adc_hal! {
549 | | pac::ADC2: (adc2),
550 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: this warning originates in the macro `adc_hal` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use the associated constant instead
|
252 | Align::Left => u16::MAX,
| ~~~
|
usage of a legacy numeric method:
src/adc.rs#L252
warning: usage of a legacy numeric method
--> src/adc.rs:252:45
|
252 | Align::Left => u16::max_value(),
| ^^^^^^^^^^^
...
543 | / adc_hal! {
544 | | pac::ADC1: (adc1),
545 | | }
| |_- in this macro invocation
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
= note: this warning originates in the macro `adc_hal` (in Nightly builds, run with -Z macro-backtrace for more info)
help: use the associated constant instead
|
252 | Align::Left => u16::MAX,
| ~~~
|
unneeded sub `cfg` when there is only one condition:
src/rcc/enable.rs#L187
warning: unneeded sub `cfg` when there is only one condition
--> src/rcc/enable.rs:187:7
|
187 | #[cfg(any(feature = "stm32f103"))] // feature = "stm32f102"
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "stm32f103"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
= note: `#[warn(clippy::non_minimal_cfg)]` on by default
|