Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed to bxcan >=0.4, <0.6 #115

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

pdgilbert
Copy link
Contributor

This PR is to relax the version requirement for bxcan. See discussion at #114 (comment)

@hannobraun
Copy link
Contributor

Thanks for the pull request, @pdgilbert!

The CI build for this PR passes, with bxcan 0.5.0. In your comment you link to your own CI builds. I didn't dig into those, but presumably they build correctly with bxcan 0.4.0. This is all good.

The problem I'm seeing is that this PR adds a new configuration that we're not testing in our CI. Changes to the code in this crate that uses bxcan might expose some of the incompatibilities between bxcan 0.4 and 0.5, which could lead to build failures.

Maybe we could add a build configuration that uses bxcan 0.4.0, using something like cargo update -p bxcan --precise 0.4.0. Not sure if that would work though. I'll just merge this PR, as it addresses a real problem. But if anyone wants to look into the CI issue, that would be very welcome.

@hannobraun hannobraun merged commit 76d0fcd into stm32-rs:master Apr 6, 2021
@hannobraun
Copy link
Contributor

I just looked into the bxcan changelog and it seems like the only change from 0.4 to 0.5 is the defmt dependency. So I guess my concern is unfounded, and there's probably no way for us to introduce any bxcan-related breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants