Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Generic variant C071RBTx support #2556

Merged
merged 4 commits into from
Nov 13, 2024
Merged

feat: Generic variant C071RBTx support #2556

merged 4 commits into from
Nov 13, 2024

Conversation

thernstig
Copy link
Contributor

Fixes #2536

@thernstig thernstig mentioned this pull request Nov 8, 2024
Closed
@thernstig
Copy link
Contributor Author

@fpistm I am not sure I got the parts right about setting the clock config. I enabled USB as the only peripheral. As you can see by #2557 I am not sure I did it right.

@fpistm fpistm self-requested a review November 8, 2024 13:50
@fpistm fpistm added the new variant Add support of new bard label Nov 8, 2024
@fpistm fpistm added this to the 2.9.0 milestone Nov 8, 2024
fpistm
fpistm requested changes Nov 8, 2024
View reviewed changes
boards.txt Show resolved Hide resolved
variants/STM32C0xx/C071R(8-B)T/generic_clock.c Outdated Show resolved Hide resolved
variants/STM32C0xx/C071R(8-B)T/generic_clock.c Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@thernstig
Copy link
Contributor Author

thernstig commented Nov 11, 2024 •
edited
Loading

@fpistm is this ready for merge? 🙂 I did not get a chance to test it, but you might see if it is correct or not directly with your experience as an ST employee.

fpistm
fpistm approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thernstig
I've squash and apply astyle.
LGTM

@fpistm fpistm mentioned this pull request Nov 12, 2024
Open
80 tasks
@thernstig
Copy link
Contributor Author

@fpistm I am not sure why the tests fail.

@fpistm
Copy link
Member

fpistm commented Nov 12, 2024

@fpistm I am not sure why the tests fail.

In fact new C071xx have a second I2C while previous first C0 don't. So it was managed by the Wire library.
I've made the fix.

thernstig
thernstig commented Nov 12, 2024
View reviewed changes
CI/build/conf/cores_config.json Show resolved Hide resolved
CI/build/conf/cores_config_ci.json Show resolved Hide resolved
cmake/boards_db.cmake Show resolved Hide resolved
@thernstig
Copy link
Contributor Author

@fpistm not sure if I can do anything about the failing link, seems unrelated. So hope you can merge 🙂 Thanks for all the help!

@fpistm fpistm merged commit 7a2786a into stm32duino:main Nov 13, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
new variant Add support of new bard
Projects
STM32 core based on ST HAL
Status: Done
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

Add support for STM32C071Rx
2 participants
@thernstig @fpistm