Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong preprocessor definitions #61

Merged
merged 5 commits into from
Jul 7, 2023
Merged

fix: wrong preprocessor definitions #61

merged 5 commits into from
Jul 7, 2023

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jul 5, 2023

Fixes #60

Wrong endif preprocessor placement when introducing new
SD pins management.

Fixes stm32duino#60

Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
Example for L4P5C(E-G)(T-U)_L4Q5CG(T-U).
So ensure to have correct setup in this case.

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm marked this pull request as draft July 6, 2023 17:24
@fpistm fpistm force-pushed the fix branch 2 times, most recently from b2299fc to 1338e43 Compare July 7, 2023 08:48
@fpistm fpistm marked this pull request as ready for review July 7, 2023 08:55
For some series some PinMap_SD* are not available.

Signed-off-by: Frederic Pillon <[email protected]>
This commit is a workaround waiting update of the core
to specify which target have or not SDMMC signals.

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm merged commit 4755239 into stm32duino:main Jul 7, 2023
10 checks passed
@fpistm fpistm deleted the fix branch July 7, 2023 12:39
@fpistm fpistm added bug 🐛 Something isn't working fix 🩹 Bug fix and removed bug bug 🐛 Something isn't working labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STEVAL-MKSBOX1V1 SDIO broken under STMduino STM32SD 1.3.0; works under 1.2.3
1 participant