File inherits from Stream: proper support for print and println of al… #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
requested changes
Aug 29, 2024
…l supported data type
fpistm
approved these changes
Sep 5, 2024
|
Hi @pschatzmann |
|
Cool, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
File must inherit from Stream: proper support for print and println of all supported data types.
The motivation for this, was that in all other SD libraries the File impelmentation is a subclass of Stream which itself is a subclass of Print.
With this change we can now also provide the files of this library to any Arduino function which expects a Stream or a Print.
Validation
I extended the test sketch Full.ino to test the readBytes() method and the printing of an integer.
Closing issues
I did not file any issue but decided to submit a pull request directly to speed up things.
see https://github.com/orgs/stm32duino/discussions/2428