-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HttpBootUri into Boot #271
Conversation
There's a minor linting issue. Can you address that? |
Absolutely, force-pushed. |
So I tested on a DELL R350 and it works, unfortunately this system does not support this Redfish field yet :-D |
Oh well, I guess we at least know it doesn't make older systems blow up. :D |
Shoot, part way there! Linter still not happy yet. |
Signed-off-by: Lukas Zapletal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Action failures from a weird caching issue I've seen before. Not related to this change, and I was able to verify locally. So just going to ignore the checks for now.
Thanks for this!
Yeah I was waiting until it passes before I make another comment, sorry about that :-) Thanks. FYI I am building a small prototype, a provisioning service for Red Hat systems, it’s an image-based provisioning via Anaconda and HTTP UEFI Boot via Redfish, fully automated: https://github.com/foresterorg/forester Thanks again. Cheers. |
I finally got to hardware testing this feature and I noticed that the field is serialized as |
If/when you are able to test, and if the casing is an issue, that is handled by giving a serialize/deserialize name to the JSON settings. An example can be seen here. |
I still don’t have access to any system that supports this, from what I have learned modern HPE systems do support it. Anyway, I want to fix this anyway: #292 |
This flag allows to override UEFI HTTP Boot URI, only works when BootSourceOverrideTarget is set to UefiHttp.
I could not find any unit test for updating boot structure, let me know if I missed it. Thanks!