Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpBootUri into Boot #271

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Add HttpBootUri into Boot #271

merged 1 commit into from
Sep 4, 2023

Conversation

lzap
Copy link
Contributor

@lzap lzap commented Aug 30, 2023

This flag allows to override UEFI HTTP Boot URI, only works when BootSourceOverrideTarget is set to UefiHttp.

I could not find any unit test for updating boot structure, let me know if I missed it. Thanks!

@stmcginnis
Copy link
Owner

There's a minor linting issue. Can you address that?

@lzap
Copy link
Contributor Author

lzap commented Sep 4, 2023

Absolutely, force-pushed.

@lzap
Copy link
Contributor Author

lzap commented Sep 4, 2023

So I tested on a DELL R350 and it works, unfortunately this system does not support this Redfish field yet :-D

@stmcginnis
Copy link
Owner

So I tested on a DELL R350 and it works, unfortunately this system does not support this Redfish field yet :-D

Oh well, I guess we at least know it doesn't make older systems blow up. :D

@stmcginnis
Copy link
Owner

Absolutely, force-pushed.

Shoot, part way there! Linter still not happy yet.

Signed-off-by: Lukas Zapletal <[email protected]>
Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Action failures from a weird caching issue I've seen before. Not related to this change, and I was able to verify locally. So just going to ignore the checks for now.

Thanks for this!

@stmcginnis stmcginnis merged commit 108becb into stmcginnis:main Sep 4, 2023
@lzap
Copy link
Contributor Author

lzap commented Sep 4, 2023

Yeah I was waiting until it passes before I make another comment, sorry about that :-)

Thanks. FYI I am building a small prototype, a provisioning service for Red Hat systems, it’s an image-based provisioning via Anaconda and HTTP UEFI Boot via Redfish, fully automated:

https://github.com/foresterorg/forester

Thanks again. Cheers.

@lzap lzap deleted the uefiuri branch September 4, 2023 14:05
@lzap
Copy link
Contributor Author

lzap commented Nov 28, 2023

I finally got to hardware testing this feature and I noticed that the field is serialized as HTTPBootURI whereas the spec says HttpBootUri. Linter made me to change the name, I am not sure if Redfish API is actually case-insensitive so it would not make any difference. Currently I loaned 6 systems from Dell and SuperMicro and any of them does not support this relatively new feature so I cannot confirm for sure :-(

@stmcginnis
Copy link
Owner

I finally got to hardware testing this feature and I noticed that the field is serialized as HTTPBootURI whereas the spec says HttpBootUri. Linter made me to change the name, I am not sure if Redfish API is actually case-insensitive so it would not make any difference. Currently I loaned 6 systems from Dell and SuperMicro and any of them does not support this relatively new feature so I cannot confirm for sure :-(

If/when you are able to test, and if the casing is an issue, that is handled by giving a serialize/deserialize name to the JSON settings. An example can be seen here.

@lzap
Copy link
Contributor Author

lzap commented Dec 11, 2023

I still don’t have access to any system that supports this, from what I have learned modern HPE systems do support it. Anyway, I want to fix this anyway: #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants