Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image diff to get baseline from default branch #211

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Update image diff to get baseline from default branch #211

wants to merge 26 commits into from

Conversation

tuliren
Copy link
Member

@tuliren tuliren commented Mar 7, 2023 •
edited
Loading

TODOs

  • Convert SVG to PNG.
  • Get file from default branch.
  • Support glob pattern.
  • Show image only if there are differences.
  • Show at most N diff images.

@stoat-app
Copy link

stoat-app bot commented Mar 7, 2023 •
edited
Loading

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
Documentation Visit 74d19ed ✅
CLI Test Coverage Visit 74d19ed ✅
Types TS Coverage (node-version: 18) Visit 74d19ed ✅
Types TS Coverage (node-version: 16) Visit 74d19ed ✅
Action Test Coverage Visit 74d19ed ✅
Action Test Coverage (single file) Visit 74d19ed ✅

Image Diff

Name Baseline Current Diff
Logo baseline current diff

Chart

Runner Memory Usage

Job Runtime

job runtime chart

debug

@tuliren tuliren mentioned this pull request Mar 8, 2023
Draft
@tuliren tuliren force-pushed the liren/improve-image-diff branch from b867939 to dc9ac02 Compare March 8, 2023 23:52
jrhizor
jrhizor reviewed Mar 9, 2023
View reviewed changes
action/src/stoatApiHelpers.ts
@@ -12,7 +12,7 @@ export type DevServerCheck = false | string;
export const STOAT_ORG = 'stoat-dev';
export const STOAT_REPO = 'stoat';
export const STOAT_ACTION_REPO = 'stoat-action';
export const INTERNAL_REPOS = [STOAT_REPO, STOAT_ACTION_REPO];
export const INTERNAL_REPOS = [STOAT_REPO, STOAT_ACTION_REPO, 'd2'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should probably allow this override in the repo we're using, not in a checked-into-the-action location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuliren @jrhizor