checkEvents() method addresses S3 generic/method consistency

CRAN-SUBMISSION

@@ -1,3 +1,3 @@
-Version: 1.6.6
-Date: 2024-03-13 11:10:49 UTC
-SHA: 7057fa002354262151936b3d73c53a6d9f474b0c
+Version: 1.6.7
+Date: 2024-04-11 11:53:04 UTC
+SHA: 859b5bcfafb03bd44ce97a810673b5fd943d92ef

DESCRIPTION

@@ -2,7 +2,7 @@ Encoding: UTF-8
 Package: goldfish
 Type: Package
 Title: Statistical Network Models for Dynamic Network Data
-Version: 1.6.7
+Version: 1.6.8
 Date: 2024-04-11
 Authors@R: c(person("James", "Hollway", role = c("aut", "dtc"), 
                     email = "[email protected]",

NEWS.md

@@ -1,3 +1,8 @@
+# goldfish 1.6.8
+
+* `checkEvents()` method addresses S3 generic/method consistency.
+* Solves broken link in the bibliography.
+
 # goldfish 1.6.7
 
 * Debug and update yaml workflow files for GitHub Actions.

R/functions_checks.R

@@ -486,7 +486,7 @@ checkDependentEvents <- function(events, eventsName, nodes, nodes2,
     tryCatch(
       {
         checkEvents(
-          nodes, events, eventsName,
+          object = nodes, events = events, eventsName = eventsName,
           updateColumn = updateColumn,
           environment = environment
         )
@@ -498,8 +498,10 @@ checkDependentEvents <- function(events, eventsName, nodes, nodes2,
   } else if (all(c("sender", "receiver") %in% names(events))) {
     tryCatch(
       {
-        checkEvents(defaultNetwork, events, eventsName, nodes, nodes2,
-          updateColumn = updateColumn, environment = environment
+        checkEvents(
+          object = defaultNetwork, events = events, eventsName = eventsName,
+          updateColumn = updateColumn, environment = environment,
+          nodes = nodes, nodes2 = nodes2
         )
       },
       error = function(e) {
@@ -552,7 +554,9 @@ checkGlobalAttribute <- function(global) {
 #   IF it's associated to a network
 # - a column "replace" OR "increment" of characters or numerics or booleans
 
-checkEvents <- function(object, ...) {
+checkEvents <- function(
+    object, events, eventsName,
+    updateColumn = TRUE, environment = environment(), ...) {
   UseMethod("checkEvents", object)
 }
 
@@ -567,7 +571,8 @@ checkEvents <- function(object, ...) {
 
 checkEvents.nodes.goldfish <- function(
     object, events, eventsName,
-    attribute = NULL, updateColumn = TRUE, environment = environment()) {
+    updateColumn = TRUE, environment = environment(),
+    attribute = NULL, ...) {
   # check attributes
   if (!is.data.frame(events)) stop("An event list should be a data frame.")
   if (!is.null(attribute)) {
@@ -710,8 +715,8 @@ checkEvents.nodes.goldfish <- function(
 
 checkEvents.network.goldfish <- function(
     object, events, eventsName,
-    nodes, nodes2 = NULL,
-    updateColumn = TRUE, environment = environment()) {
+    updateColumn = TRUE, environment = environment(),
+    nodes, nodes2 = NULL, ...) {
   # get data frames of presence events over the nodes sets
   isTwoMode <- !is.null(nodes2)
   nodesName <- c(

R/functions_data.R

@@ -882,7 +882,8 @@ linkEvents.nodes.goldfish <- function(x, changeEvents, attribute, ...) {
     {
       checkEvents(
         object = x, events = changeEvents, eventsName = objEventCurr,
-        attribute = attribute, environment = linkEnvir
+        environment = linkEnvir,
+        attribute = attribute
       )
     },
     error = function(e) {
@@ -954,7 +955,8 @@ linkEvents.network.goldfish <- function(x, changeEvents,
     {
       checkEvents(
         object = x, events = changeEvents, eventsName = objEventCurr,
-        nodes = nodes, nodes2 = nodes2, environment = linkEnvir
+        environment = linkEnvir,
+        nodes = nodes, nodes2 = nodes2
       )
     },
     error = function(e) {

cran-comments.md

@@ -7,4 +7,7 @@
 
 ## R CMD check results
 
-0 errors | 0 warnings | 0 note
+0 errors | 0 warnings | 1 note
+
+* This is a new release.
+* `checkEvents()` method addresses S3 generic/method consistency.

inst/REFERENCES.bib

@@ -17,7 +17,7 @@ @article{Stadtfeld2017Coordination
   number = {1},
   pages = {1-40},
   year = {2017},
-  doi = {10.1177/0081175017703776},
+  doi = {10.1177/0081175017709295},
   url = {https://doi.org/10.1177/0081175017709295}
 }