Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recording rule #154

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented May 27, 2024

The related issue: https://issues.redhat.com/browse/ACM-11628

Per request from https://issues.redhat.com/browse/MON-3884?focusedId=24790834&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24790834, add a recording rule for the metric acm_managed_cluster_worker_cores. It will be sent to the telemetry side instead of the raw metric.

@elgnay elgnay force-pushed the recording-rules branch 5 times, most recently from 72a0dfa to 09ad3b9 Compare May 27, 2024 18:08
Signed-off-by: Yang Le <[email protected]>
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haoqing0110
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, haoqing0110

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 18893a3 into stolostron:main May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants