Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dependencies #171

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented Sep 19, 2024

Refer to the go 1.22 release notes

go get is no longer supported outside of a module in the legacy GOPATH mode (that is, with GO111MODULE=off). Other build commands, such as go build and go test, will continue to work indefinitely for legacy GOPATH programs.

Before upgrading to 1.22, this PR is to remove GO111MODULE=off and replace go get with go install for dependencies, since the release repo reports the below error when just upgrading the golang version to 1.22.

INFO[2024-09-19T02:18:00Z] which: no kustomize in (/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/go/bin:/opt/sonar/bin:/usr/local/kubebuilder/bin)
which: no patter in (/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/go/bin:/opt/sonar/bin:/usr/local/kubebuilder/bin:/usr/local/kubebuilder/bin)
Installing patter ...
go: modules disabled by GO111MODULE=off; see 'go help modules'
make: *** [Makefile:42: dependencies] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-09-19T02:17:59Z"} 
INFO[2024-09-19T02:[18](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/56897/rehearse-56897-pull-ci-stolostron-clusterlifecycle-state-metrics-backplane-2.7-check/1836587508071141376#1:build-log.txt%3A18):00Z] Ran for 11m55s                               
ERRO[2024-09-19T02:18:00Z] Some steps failed:                           
ERRO[2024-09-19T02:18:00Z] 
  * could not run steps: step check failed: test "check" failed: could not watch pod: the pod ci-op-psb715dd/check failed after 27s (failed containers: test): ContainerFailed one or more containers exited
  *

@haoqing0110 haoqing0110 force-pushed the br_upgrade-golang branch 2 times, most recently from 8cc404f to 166c658 Compare September 19, 2024 07:06
@haoqing0110 haoqing0110 changed the title upgrade golang to 1.22 preupgrade golang to 1.22 Sep 19, 2024
@haoqing0110 haoqing0110 force-pushed the br_upgrade-golang branch 4 times, most recently from fcaa1b1 to 6b493f1 Compare September 19, 2024 15:18
Signed-off-by: haoqing0110 <[email protected]>
Copy link

sonarcloud bot commented Sep 20, 2024

@haoqing0110 haoqing0110 changed the title preupgrade golang to 1.22 remove unused dependencies Sep 20, 2024
@xuezhaojun
Copy link
Contributor

Good catch!
/lgtm

/hold
Unhold if you feel good to go @haoqing0110

Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haoqing0110,xuezhaojun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haoqing0110
Copy link
Member Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 102f617 into stolostron:main Sep 20, 2024
9 checks passed
@haoqing0110 haoqing0110 deleted the br_upgrade-golang branch September 20, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants